Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration/Upgrading: Add index page for "Upgrading" section #43

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 26, 2024

About

Spend a little index page on the "Upgrading" section, in order to save vertical space within the primary navigation, and to improve guidance.

Before / After

With screenshots.

image image

Preview

/cc @surister, @karynzv, @marijaselakovic, @hammerhead, @proddata, @wierdvanderhaar, @msbt, @matkuliak

@amotl amotl marked this pull request as ready for review February 26, 2024 20:18
@amotl amotl changed the title Refactoring: Add index page for "Upgrading" section Sanding: Add index page for "Upgrading" section Feb 26, 2024
@amotl amotl added the sanding-1200 Fine sanding. label Feb 26, 2024
@amotl amotl changed the title Sanding: Add index page for "Upgrading" section Administration/Upgrading: Add index page for "Upgrading" section Feb 26, 2024
@amotl amotl added the guidance Matters of layout, shape, and structure. label Feb 26, 2024
@amotl amotl requested review from surister, hammerhead, hlcianfagna and proddata and removed request for hlcianfagna, seut and surister February 27, 2024 09:38
@proddata

This comment was marked as resolved.

@amotl

This comment was marked as resolved.

Comment on lines 1 to 11
# Upgrading

Guidelines about upgrading CrateDB clusters.

```{toctree}
:maxdepth: 2

planning
rolling
full
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, now that we are talking about it, what do you think about improving the wording by stripping redundancy, at least on the labels within the primary navigation?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Rolling Upgrade" and "Full Restart Upgrade" are fine there.
"General Guidelines" or "Guidelines" might be sufficient though.

Spend a little index page on the "Upgrading" section, in order to save
vertical space within the primary navigation, and to improve guidance.
Comment on lines +8 to +10
Guidelines <planning>
rolling
full
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted the patch correspondingly to use "Guidelines" as the label within the primary navigation. The page title itself hasn't been changed, and is still "General Upgrade Guidelines".

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could just move the "Guidelines" into "Upgrading", as the Execution part just links to Rolling / Full Upgrade

Copy link
Member Author

@amotl amotl Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to admit we are only looking at the most prominent details mostly on the 1st level of this documentation tree now, with only occasional detours into the 2nd and 3rd levels. We will carry that over to a subsequent iteration, thanks.

@amotl amotl mentioned this pull request Feb 27, 2024
16 tasks
@amotl amotl merged commit 890fd8b into main Feb 27, 2024
3 checks passed
@amotl amotl deleted the amo/compress-upgrade branch February 27, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Matters of layout, shape, and structure. sanding-1200 Fine sanding.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants