Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix highlighting for etl pages #91

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

proddata
Copy link
Member

@proddata proddata commented Jun 6, 2024

Summary of the changes / Why this is an improvement

Let's fix this in the most straightforward way.


kudos to @amotl for finding this

Note

"So let's find the closest header in the document and try with that one."
https://github.com/petermd/sphinx_rtd_theme/blob/0.2.4/js/theme.js#L93-L123

📺 Preview
⬆️ ⬆️ ⬆️

Checklist

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that improves something, I am happy. Thanks. Feels like hacking on the edge of Sphinx, but c'est la vie?

@proddata
Copy link
Member Author

proddata commented Jun 6, 2024

Feels like hacking on the edge of Sphinx, but c'est la vie?

Reading through the js snippet and sphinx docs you linked, I think that is exactly the way it is supposed to work 🙈

"If it is stupid but it works, it isn't stupid."

@proddata proddata merged commit 28ce320 into main Jun 6, 2024
3 checks passed
@proddata proddata deleted the proddata/fix-highlighting branch June 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants