CI: Add release workflow for staging the Python package through GHA to PyPI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the lines, the patch includes "developer guide" documentation for both Python and JavaScript.
amotl
commented
Jun 17, 2024
Comment on lines
+63
to
+69
| Run specific tests: | ||
|
|
||
| ??? | ||
|
|
||
| Format code: | ||
|
|
||
| ??? |
There was a problem hiding this comment.
Didn't know relevant incantations for the JavaScript domain. Are there any?
There was a problem hiding this comment.
npm test and npm build
But I can add them later in the upcoming javascript patch
There was a problem hiding this comment.
Ah sorry I didn't see the "?", no currently there is no format, maybe we should add it int he future with prettier, for running a single test is npm test -- other.test.js
There was a problem hiding this comment.
Thanks. Yeah, please fill in the gaps, or delete sections where applicable.
.github/workflows/release.yml
Outdated
Comment on lines
30
to
36
| - name: Publish package to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN }} |
There was a problem hiding this comment.
The GHA workflow needs the PYPI_API_TOKEN secret, which has just been added to the repository.
surister
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
A release workflow for staging the Python package through GHA to PyPI.
Along the lines, the patch includes "developer guide" documentation for both Python and JavaScript.