MongoDB: Fix and verify Zyp transformations #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/zyp-int64-timestamp
branch
from
33cefcb
to
e8e98c0
Compare
amotl
requested review from
seut
and removed request for
surister and
wierdvanderhaar
|
Hi. GH-243 builds upon this little fixup patch, so I am humbly asking about also reviewing and acknowledging this one. Thank you in advance. 🙏 |
surister
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Zyp transformations for MongoDB had a little bug where it boosts a schema override when introspecting and translating a MongoDB collection schema into a CrateDB SQL DDL schema. Also, transformations needed validation on behalf of an integration test case.
This patch fixes the flaw, and uses a
boring but not unusualbasic case to translate int64 fields containing unixtime values to native timestamp ones, in order to validate schema overrides.References
/cc @karynzv, @hammerhead, @matkuliak, @juanpardo, @proddata, @widmogrod, @surister, @simonprickett