DynamoDB: Add pagination support for full-load table loader
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
dynamodb-full-load-batch
branch
2 times, most recently
from
d7195d3 to
5b595d9
Compare
amotl
commented
Sep 2, 2024
pyproject.toml
Outdated
| "commons-codec>=0.0.12", | ||
| "commons-codec @ git+https://github.com/crate/commons-codec.git@dynamodb-full-load-batch", |
There was a problem hiding this comment.
commons-codec needs to converge into a release beforehand, after merging crate/commons-codec#43.
There was a problem hiding this comment.
commons-codec v0.0.14 has been released.
amotl
force-pushed
the
dynamodb-full-load-batch
branch
from
5b595d9 to
3a98776
Compare
amotl
force-pushed
the
dynamodb-full-load-batch
branch
3 times, most recently
from
46bbc16 to
0807320
Compare
amotl
force-pushed
the
dynamodb-full-load-batch
branch
2 times, most recently
from
f853e90 to
ee5ecd8
Compare
surister
approved these changes
Sep 2, 2024
amotl
force-pushed
the
dynamodb-full-load-batch
branch
2 times, most recently
from
a063a5b to
5747aed
Compare
amotl
force-pushed
the
dynamodb-full-load-batch
branch
from
5747aed to
d32cabd
Compare
amotl
commented
Sep 2, 2024
Comment on lines
+39
to
+40
| if key is not None: | ||
| scan_kwargs.update({"ExclusiveStartKey": key}) |
There was a problem hiding this comment.
This spot, not covered yet, certainly needs a software test. I didn't pay enough attention, and Codecov didn't have access to the repository beforehand, so it did not run a corresponding admonition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
For making DynamoDB
full-loadoperations more efficient, use CrateDB's bulk operations. With this patch, the batching towards CrateDB is implemented by doing pagination on the DynamoDB source database. For other strategies, see backlog.References
to_sql()to accept list of records commons-codec#43Backlog
For subsequent iterations:
/cc @wierdvanderhaar, @hlcianfagna