Added ability to schedule sql jobs #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taliik
force-pushed
the
f/gc-poc
branch
4 times, most recently
from
7cd01eb
to
e059a1a
Compare
Taliik
changed the title
Taliik
requested review from
plaharanne,
tomach,
WalBeh,
juanpardo and
SStorm
as code owners
plaharanne
reviewed
Jan 22, 2024
plaharanne
reviewed
Jan 22, 2024
docs/commands/gcjobs.rst
Outdated
| ``gc`` | ||
| ====== | ||
|
|
||
| The ``gc`` command lets you manage scheduled sql jobs for your cluster. |
There was a problem hiding this comment.
I'm wondering if the keyword here should be something likescheduled-sql instead of gc. I guess we could have other GC features in croud later, it might be confusing. idk.
There was a problem hiding this comment.
I think I agree here, gc is not really a public facing thing...
Maybe croud scheduled-jobs?
plaharanne
reviewed
Jan 22, 2024
my_table.csv
Outdated
There was a problem hiding this comment.
Is it used in the tests? I can't find it.
There was a problem hiding this comment.
thanks for finding this. It appears that when you run the whole test suit, the test test_export_job_create writes the my_table.csv file but does not clean it up ...
Taliik
force-pushed
the
f/gc-poc
branch
3 times, most recently
from
cc7c5af
to
7e380f5
Compare
Taliik
changed the title
plaharanne
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Checklist