Update to mypy 1.10 #506
Update to mypy 1.10 #506
Conversation
amotl
force-pushed
the
update-mypy
branch
3 times, most recently
from
3c2dd03
to
0541502
Compare
amotl
requested review from
plaharanne,
tomach,
WalBeh,
Taliik,
juanpardo and
SStorm
as code owners
croud/regions/commands.py
Outdated
| @@ -138,7 +139,7 @@ def regions_delete(args: Namespace) -> None: | |||
| print_response( | |||
| data=data, | |||
| errors={ | |||
| "message": region_errors.get("message"), | |||
| "message": cast(str, region_errors.get("message")), | |||
There was a problem hiding this comment.
That might be a viable alternative instead of using a cast. wdyt?
| "message": cast(str, region_errors.get("message")), | |
| "message": region_errors.get("message", "unknown error"), |
There was a problem hiding this comment.
Yes, it makes sense to have a meaningful message.
There was a problem hiding this comment.
Hi. I changed the code according to the suggestion. The patch is now ready for review, if you don't have any other objections.
There was a problem hiding this comment.
Bumping the mypy version should be done in
.github/dependabot.ymltoo.
Right. Done.
| self.server.on_token(token) | ||
| self.server.on_token(token) # type: ignore[attr-defined] |
There was a problem hiding this comment.
I've marked this attribute to be ignored. Apparently, the on_token is a non-standard extension, where the type checker trips on, but in reality, all just works well?
| [tool.mypy] | ||
| check_untyped_defs = true | ||
| ignore_missing_imports = true | ||
| implicit_optional = true | ||
| install_types = true | ||
| non_interactive = true |
There was a problem hiding this comment.
Well, I used the chance to introduce a pyproject.toml, which can absorb more project metadata in the future while we go. I hope you agree.
There was a problem hiding this comment.
sounds good. Fabian is working on migrating our projects to Poetry, I guess he would eventually create it anyway.
There was a problem hiding this comment.
Is your decision on Poetry already fixed? I think classic setuptools/pip is mature enough today so you don't exactly need Poetry, mostly. Also, it is aging a bit.
We are only using it on Wetterdienst today, and abstained from bringing it into many other projects so far, because, well, we didn't actually see an advantage given that vanilla pip/setuptools supports pyproject.toml configurations well, and it certainly adds a bit of drag as well.
/cc @Taliik
| # type: ignore | ||
|
|
There was a problem hiding this comment.
On test_printer.py, mypy emits many type errors, so I figured it would be good to ignore them altogether. Let me know if you think different, then it will probably be a bigger story.
amotl
force-pushed
the
update-mypy
branch
3 times, most recently
from
bb3ec72
to
8820ed2
Compare
|
Hi. I've updated this PR according to corresponding suggestions from code review. Can you have a final look? |
About
Update to the most recent version of mypy, in order to support the update to Python 3.11 on a subsequent iteration.