Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This and that #12

Merged
merged 8 commits into from
Sep 12, 2023
Merged

This and that #12

merged 8 commits into from
Sep 12, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Sep 10, 2023 •
edited
Loading

About

A few more improvements on different ends.

Level 1

  • Add patch for SQLAlchemy Inspector's get_table_names again. Contrary to the latest assessment, we still need it, see below.

Level 2

  • CLI: Add mlflow-cratedb cratedb --version command
  • Project: Add versioningit, for effortless versioning
  • Tests: Provide fixture testdrive_engine for the whole test suite
  • Reorder CrateDB SQLAlchemy Dialect polyfills
  • Update documentation

@amotl amotl marked this pull request as ready for review September 10, 2023 09:35
@amotl amotl mentioned this pull request Sep 12, 2023
Merged
Base automatically changed from adjust-tests to main September 12, 2023 10:50
@amotl amotl merged commit 2ea2e70 into main Sep 12, 2023
1 check passed
@amotl amotl deleted the iterate-1 branch September 12, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammerhead hammerhead hammerhead approved these changes

@seut seut Awaiting requested review from seut

@hlcianfagna hlcianfagna Awaiting requested review from hlcianfagna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotl @hammerhead