Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few missing columns to make the Models tab load in the UI #21

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add a few missing columns to make the Models tab load in the UI #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b5753a
Add a few missing columns to make the Models tab load in the UI
hammerhead Sep 14, 2023
424b51b
Ignore `build` and `model` folders
hammerhead Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/.ruff_cache
/.vagrant
/.venv*
/build

/dist

Expand All @@ -15,3 +16,4 @@ __pycache__

/mlartifacts
/mlruns
/model
11 changes: 8 additions & 3 deletions mlflow_cratedb/adapter/ddl/cratedb.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ CREATE TABLE IF NOT EXISTS "model_versions" (
"name" TEXT NOT NULL,
"version" INTEGER NOT NULL,
"creation_time" BIGINT, -- default=get_current_time_millis
"last_update_time" BIGINT, -- default=get_current_time_millis
"last_updated_time" BIGINT, -- default=get_current_time_millis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent in MLflow across the tables (last_update_time vs. last_updated_time).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting.

"description" TEXT,
"user_id" TEXT,
"current_stage" TEXT,
Expand All @@ -94,8 +94,11 @@ CREATE TABLE IF NOT EXISTS "params" (

CREATE TABLE IF NOT EXISTS "registered_models" (
"name" TEXT NOT NULL,
"key" TEXT NOT NULL,
"value" TEXT
"key" TEXT DEFAULT GEN_RANDOM_TEXT_UUID() NOT NULL,
"value" TEXT,
"creation_time" BIGINT,
"last_updated_time" BIGINT,
"description" TEXT
);

CREATE TABLE IF NOT EXISTS "registered_model_aliases" (
Expand All @@ -106,6 +109,8 @@ CREATE TABLE IF NOT EXISTS "registered_model_aliases" (

CREATE TABLE IF NOT EXISTS "registered_model_tags" (
"name" TEXT NOT NULL,
"key" TEXT NOT NULL,
"value" TEXT NOT NULL,
"creation_time" BIGINT, -- default=get_current_time_millis
"last_update_time" BIGINT, -- default=get_current_time_millis
"description" TEXT
Expand Down