Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OCI image sizes #63

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Optimize OCI image sizes #63

merged 1 commit into from
Nov 6, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 6, 2023

About

Now that we need gcc to satisfy the psutil dependency of MLflow, we uninstall it right away. In order that this makes sense, all commands (install/uninstall) need to be done in one run.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@amotl amotl force-pushed the amo/fix-oci-psutil branch from fd4585d to b34e1c4 Compare November 6, 2023 09:31
@amotl
Copy link
Member Author

amotl commented Nov 6, 2023

Info

skopeo --version
skopeo version 1.11.2

Before

export IMAGE=docker://ghcr.io/crate-workbench/mlflow-cratedb:pr-62
export IMAGE=docker://ghcr.io/crate-workbench/ml-runtime:pr-62
skopeo inspect --override-os=linux "$IMAGE" | jq '[ .LayersData[].Size ] | add'
mlflow-cratedb ml-runtime
350,741,048 1,340,810,890

After

export IMAGE=docker://ghcr.io/crate-workbench/mlflow-cratedb:pr-63
export IMAGE=docker://ghcr.io/crate-workbench/ml-runtime:pr-63
skopeo inspect --override-os=linux "$IMAGE" | jq '[ .LayersData[].Size ] | add'
mlflow-cratedb ml-runtime
248,939,824 1,239,084,803

@amotl amotl force-pushed the amo/fix-oci-psutil branch 3 times, most recently from 40e2e96 to 4e2c0dc Compare November 6, 2023 09:56
Base automatically changed from amo/fix-oci-psutil to main November 6, 2023 10:23
When installing and uninstalling packages only needed at build time,
it needs to be done in one run to save layer space.
@amotl amotl marked this pull request as ready for review November 6, 2023 11:01
@amotl amotl merged commit 7600b9b into main Nov 6, 2023
4 checks passed
@amotl amotl deleted the amo/oci-optimize branch November 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant