Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Improve page about migrating to sqlalchemy-cratedb #179

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 14, 2024

About

The first iteration of this page has been rough. The second one intends to improve the situation.

Preview

https://sqlalchemy-cratedb--179.org.readthedocs.build/migrate-from-crate-client.html

Review

Please advise if you think matters can be conveyed better, best using concrete suggestions.

@amotl amotl added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Nov 14, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 14, 2024
@amotl amotl marked this pull request as ready for review November 14, 2024 22:43
`crate.client.sqlalchemy`, you will need to import the same symbols from
`sqlalchemy_cratedb` from now on.
a drop-in replacement with no noticeable changes. In November 2024,
`crate-1.0.0` has been released, which dropped including the SQLAlchemy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which dropped including

Not super clear, maybe could be rephrased?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks. @kneth: Coming up with improvement proposals right away will tremendously help.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like

With the release of crate-1.0.0 in November 2024, the support of the SQLAlchemy dialect was dropped. See the "Upgrade procedure" section for further information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I've used your suggestion 1:1, and compressed it by a few more words.

With the release of crate-1.0.0 in November 2024, the SQLAlchemy dialect was
dropped from this package. See the "Upgrade procedure" section for further
information.

Copy link

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @hlcianfagna's comment is resolved, I am all in 😄

@amotl amotl force-pushed the amo/improve-migration-notes branch from 59f6be1 to 2464550 Compare November 15, 2024 17:36
@amotl amotl merged commit 4a06f99 into main Nov 15, 2024
28 checks passed
@amotl amotl deleted the amo/improve-migration-notes branch November 15, 2024 17:38
@amotl amotl restored the amo/improve-migration-notes branch November 15, 2024 20:59
@amotl amotl deleted the amo/improve-migration-notes branch November 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants