Update to crate-2.0.0, which uses orjson for JSON marshalling
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Jan 16, 2025
pyproject.toml
Outdated
| "crate>=1.0.0.dev2,<2", | ||
| "crate>=2.0.0.dev1,<3", |
There was a problem hiding this comment.
In order to permit installation of crate-2.0.0, we need to bump the upper version bound anyway. Do you think we should also bump the lower bound, as outlined here?
In principle, we can be lenient and keep crate>=1.0.0. In practice, we can apply a little more force here that when upgrading sqlalchemy-cratedb, crate-python will automatically be upgraded as well.
There was a problem hiding this comment.
For me it sounds very fine to increase the lower bound, everything else looks like not worth doing it (I don't really see the need to be able to use an older crate-python version with a newer sqlalchemy dialect)
There was a problem hiding this comment.
Fine. Let's merge the PR as-is then?
This was referenced Jan 16, 2025
kneth
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Validate and bring in an improvement to crate-python.
orjsonto improve JSON marshalling performance crate-python#691References
crate-2.0.0, which usesorjsonfor JSON marshalling cratedb-toolkit#349