Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FormFlowInterface in TwigExtension instead of concrete class #295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use FormFlowInterface in TwigExtension instead of concrete class #295

wants to merge 2 commits into from

Conversation

acrolyt
Copy link

@acrolyt acrolyt commented Sep 11, 2017

If one wants to overwrite the FormFlow class or implement his own implementation, the original TwigExtension will work out of the box

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Changes Unknown when pulling e0b0605 on acrolyt:use-interface-in-twig-extension into ** on craue:master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e0b0605 on acrolyt:use-interface-in-twig-extension into ** on craue:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e0b0605 on acrolyt:use-interface-in-twig-extension into ** on craue:master**.

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Changes Unknown when pulling df75c7d on acrolyt:use-interface-in-twig-extension into ** on craue:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling df75c7d on acrolyt:use-interface-in-twig-extension into ** on craue:master**.

@craue
Copy link
Owner

craue commented Sep 19, 2017

It's not that easy because methods getDynamicStepNavigationInstanceParameter and getDynamicStepNavigationStepParameter (used in FormFlowUtil) are not part of FormFlowInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants