Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #422

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Allow Symfony 7 #422

merged 1 commit into from
Jan 11, 2024

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Dec 3, 2023

Adding return type would be BC break for someone extending these files and overriding those method without adding the void return type, but I guess this is unlikely to happen, apparently these extension are not meant to be extended.

Closes #423

@coveralls
Copy link

coveralls commented Dec 3, 2023

Coverage Status

coverage: 99.483%. remained the same
when pulling da49c8d on franmomu:sf7
into 0e34cf9 on craue:master.

@mjmeijerman
Copy link

Would be nice to have this one merged!

@craue craue merged commit 4244fd7 into craue:master Jan 11, 2024
9 of 14 checks passed
@craue
Copy link
Owner

craue commented Jan 11, 2024

Thank you, @franmomu.

@franmomu franmomu deleted the sf7 branch January 11, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Symfony 7
5 participants