fix building of shared extensions (grpc, simdjson, soap) #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meh, it looks like that's not enough. may have to remove -Wl,--as-needed instead (just for ImageMagick) |
… (stupid grpc build thirdparty hardcode)
|
closes #908 |
henderkes
changed the title
henderkes
changed the title
Comment on lines
+15
to
+19
| $original_ldflags = $this->builder->arch_ld_flags; | ||
| if (str_contains($this->builder->arch_ld_flags, '-Wl,--as-needed')) { | ||
| $this->builder->arch_ld_flags = str_replace('-Wl,--as-needed', '', $original_ldflags); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it possible to change only for this scope rather than modifying builder property? I don't think modifying builder's value is the best idea.
There was a problem hiding this comment.
I can't think of a way, unfortunately, other than patching imagemagick's ./configure, but that would be much worse than temporarily changing the ldflags.
|
I'll work on it next week. On a business trip until Sunday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes grpc shared compilation - it just ignores CXXFLAGS and instead abuses CPPFLAGS for what should in CXXFLAGS...
closes #908
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.