Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for typical phoenix setup #19

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix docs for typical phoenix setup #19

merged 1 commit into from
Jun 12, 2024

Conversation

nshafer
Copy link
Contributor

@nshafer nshafer commented Jun 11, 2024

Just a quick fix to the README, and specifically the Phoenix docs. Since the rest of the README assumes they would bun add package inside the "assets/" dir, which would create "assets/package.json" then bun needs to be configured to find the deps directory up one directory, or "../deps". Works like a charm in a new phoenix app.

Thanks for the package! Just replaced esbuild with it.

@crbelaus
Copy link
Owner

Thanks @nshafer! I am really glad that you find this useful 🙇

@crbelaus crbelaus merged commit 8020740 into crbelaus:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants