Unzip the Bun binary only #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crbelaus
force-pushed
the
unzip-bun-binary-only
branch
2 times, most recently
from
829d60d to
53e7bab
Compare
crbelaus
force-pushed
the
unzip-bun-binary-only
branch
from
53e7bab to
8da52e7
Compare
Some versions of Bun (such as 1.1.42) contain more files in the zip archive. We are just interested in the bun binary.
crbelaus
force-pushed
the
unzip-bun-binary-only
branch
from
8da52e7 to
3ca2cc3
Compare
|
works, and code looks solid |
|
@crbelaus I tried this as well and it seems to be working, code looks good too 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some versions of Bun contain multiple directories in the Zip archive. For example, this is the output when extracting the Bun 1.1.42 on MacOS archive:
➜ ~/Documents unzip ./bun-darwin-aarch64.zip Archive: bun-darwin-aarch64.zip creating: bun-darwin-aarch64/ inflating: bun-darwin-aarch64/bun creating: __MACOSX/ creating: __MACOSX/bun-darwin-aarch64/ inflating: __MACOSX/bun-darwin-aarch64/._bunThis pull request extracts the bun binary only and discards the rest of the Zip archive contents, which we don't need.