Skip to content

Add language to metrics #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add language to metrics #4758

wants to merge 1 commit into from

Conversation

albfan
Copy link
Contributor

@albfan albfan commented May 16, 2025

fixes #4755

Summary by Sourcery

New Features:

  • Capture system language from LANG environment variable and include it in analytics traits on Linux

Copy link

sourcery-ai bot commented May 16, 2025

Reviewer's Guide

This PR extends Linux analytics traits by capturing the system’s LANG environment variable and including it in the metrics payload.

File-Level Changes

Change Details Files
Include language setting in analytics traits on Linux
  • Retrieve LANG from the environment using os.Getenv
  • Chain a Set("lang", ...) call onto the existing traits builder
pkg/crc/segment/traits_linux.go

Assessment against linked issues

Issue Objective Addressed Explanation
#4755 Gather platform, OS, language, and country information for telemetry.
#4755 Identify crc usages. The PR only adds language information to the metrics and does not identify crc usages.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@albfan albfan marked this pull request as draft May 16, 2025 08:46
@openshift-ci openshift-ci bot requested review from anjannath and cfergeau May 16, 2025 08:46
Copy link

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @albfan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -17,5 +18,6 @@ func traits() analytics.Traits {
}
return base.
Set("os_release_name", details.Name).
Set("os_release_version_id", details.VersionID)
Set("os_release_version_id", details.VersionID).
Set("lang", os.Getenv("LANG"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider using os.LookupEnv to avoid adding empty lang trait

os.Getenv returns an empty string if LANG isn’t set, resulting in an empty 'lang' trait. Use os.LookupEnv to only set the trait when LANG is defined.

@albfan
Copy link
Contributor Author

albfan commented May 16, 2025

This still miss mac and windows implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info provided in telemetry
1 participant