Assorted fixes #319
Open
Assorted fixes #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideLowered verbosity for startup logs, standardized flag formatting in the gvproxy script, and corrected the default RESTful URI description in the usage documentation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @cfergeau - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
nirs
approved these changes
Jun 5, 2025
contrib/scripts/start-gvproxy.sh
Outdated
| @@ -23,7 +23,7 @@ set -exuo pipefail | |||
| DISK_IMAGE="${1?Usage: $0 diskimage}" | |||
| VM_NAME="$(basename ${DISK_IMAGE})" | |||
|
|
|||
| ${GVPROXY} -mtu 1500 -ssh-port 2223 -listen-vfkit unixgram://$(pwd)/${VM_NAME}.sock -log-file ${VM_NAME}.gvproxy.log --pid-file ${VM_NAME}.gvproxy.pid & | |||
| ${GVPROXY} -mtu 1500 -ssh-port 2223 -listen-vfkit unixgram://$(pwd)/${VM_NAME}.sock -log-file ${VM_NAME}.gvproxy.log -pid-file ${VM_NAME}.gvproxy.pid & | |||
There was a problem hiding this comment.
I would use -- for all commands since it is more consistent with other commands in this file, and most commands, but this is good enough.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nirs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
They are dumping some internal data structures using %+v which is not very user friendly. Signed-off-by: Christophe Fergeau <[email protected]>
Signed-off-by: Christophe Fergeau <[email protected]>
By default it’s set to `none://`: ``` pkg/cmdline/cmdline.go:const DefaultRestfulURI = "none://" ``` Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One doc fix reported in containers/krunkit#51 (comment)
One consistency fix reported in #317 (comment)
And silencing of 2 debug-looking logs.
Summary by Sourcery
Silence nonessential logs, standardize script flag naming, and improve documentation clarity for the RESTful service default
Enhancements:
Documentation: