Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plan9 support #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Plan9 support #206

wants to merge 2 commits into from

Conversation

rminnich
Copy link

No description provided.

g.lenda added 2 commits February 12, 2025 21:56
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
@creack
Copy link
Owner

creack commented Feb 12, 2025

Thank you for the PR!

Something is off with the build directive, can you take a look?

@MDr164
Copy link

MDr164 commented Mar 4, 2025

Something is off with the build directive, can you take a look?

@rminnich your build tags are slightly off, I attached a patch that should fix them:

From 192e9680a44820c838964baa4f51bc82917b9307 Mon Sep 17 00:00:00 2001
From: Marvin Drees <[email protected]>
Date: Tue, 4 Mar 2025 18:20:15 +0100
Subject: [PATCH] Fix build tags for Plan9

Signed-off-by: Marvin Drees <[email protected]>
---
 ioctl_inner.go  | 2 +-
 start.go        | 2 +-
 winsize_unix.go | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ioctl_inner.go b/ioctl_inner.go
index 0ded8bc..e8ec0ea 100644
--- a/ioctl_inner.go
+++ b/ioctl_inner.go
@@ -1,5 +1,5 @@
 //go:build !windows && !solaris && !aix && !plan9
-// +build !windows,!solaris,!aix
+// +build !windows,!solaris,!aix,!plan9

 package pty

diff --git a/start.go b/start.go
index 781bb68..213f7b3 100644
--- a/start.go
+++ b/start.go
@@ -1,5 +1,5 @@
 //go:build !windows && !plan9
-// +build !windows !plan9
+// +build !windows,!plan9

 package pty

diff --git a/winsize_unix.go b/winsize_unix.go
index 8fe007b..6eca932 100644
--- a/winsize_unix.go
+++ b/winsize_unix.go
@@ -1,5 +1,5 @@
 //go:build !windows && !plan9
-// +build !windows !plan9
+// +build !windows,!plan9

 package pty

--
2.47.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants