Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts browserstack interactions to dedicated class
This makes our main class slimmer and less verbose compared to the previous one.
Move away binary config to its own class
Previously, when we want to use our own browserstack-local binary we should do like this:
Now, we should do like this instead
Change
LocalProcess
constructor signaturePreviously, its first param was browserstack-local binary path, now it only require the array of arguments that will passed to the binary. It's the job of
LocalBinary
class to handle the path, anyway.Change
SupportsBrowserStack
toWithBrowserStack
There's nothings wrong with
SupportsBrowserStack
actually, just to follow the convention usingWith...
as prefix I believe would be better for the long run.As of now, I'll keep the
SupportsBrowserStack
but mark it as deprecated so for those who still using this class won't get any errors when they run their tests.