Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Logo Overlap with Menu Button on Small Screen Sizes (e.g., iPhone SE) #497

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MAYANK12SHARMA
Copy link

@MAYANK12SHARMA MAYANK12SHARMA commented Jan 5, 2025

Fixes

Description

In the responsive design, when the screen size is approximately 340px by 425px or when viewed on mobile devices like the iPhone SE, the logo (.identity-logo) is partially by the menu button. This causes a visual overlap that affects the aesthetic and usability of the interface.

The issue occurs because the current dimensions of the logo are too large for the limited space available at these screen widths. Adjusting the size of the logo or menu button and ensuring proper spacing can resolve the overlap and maintain a clean, professional appearance on smaller devices.

Steps to Reproduce:

Open the website on a screen size of 340px by 425px or on an iPhone SE.
Observe the overlap between the logo and the menu button in the header section.

Tests

Screenshots

Before fixing it

image


After fixing it

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MAYANK12SHARMA MAYANK12SHARMA requested review from a team as code owners January 5, 2025 18:19
@MAYANK12SHARMA MAYANK12SHARMA requested review from TimidRobot and possumbilities and removed request for a team January 5, 2025 18:19
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!

The upstream files should not be modified here. Instead, please override in cc_legal_tools/static/cc-legal-tools/base.css.

Please also see Vocabulary - Docs - Upstream/Downstream Change Flow.

(I expect this is also a bug in creativecommons/vocabulary, or will be once Translations are supported upstream)

@TimidRobot TimidRobot self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Improve language option
2 participants