Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance accessibility by adding ARIA attributes and IDs to navigation… #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance accessibility by adding ARIA attributes and IDs to navigation… #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions specimen/contexts/archive-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading"">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/blog-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/blog-post.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/default-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explor-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/home-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/license-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/person-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/program-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/program-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/search-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
10 changes: 5 additions & 5 deletions specimen/contexts/team-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

<header>
<div class="masthead">
<h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<h1 id="logo-heading"><a class="identity-logo product" href="#">Vocabulary</a></h1>
<button class="expand-menu">Menu</button>
<nav class="primary-menu">
<nav class="primary-menu" aria-labelledby="logo-heading">
<ul>
<li><a href="#">About</a></li>
<li><a href="#">Contact</a></li>
Expand All @@ -30,7 +30,7 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
</ul>
</nav>

<nav class="ancillary-menu">
<nav class="ancillary-menu" aria-label="Ancillary navigation">
<ul>
<li><button class="locale icon-attach fa-globe">English</button></li>
<li><a class="donate icon-attach fa-heart" href="#">Donate</a></li>
Expand All @@ -46,11 +46,11 @@ <h1><a class="identity-logo product" href="#">Vocabulary</a></h1>
<!-- (optional main CC logo, p, link on non-home site back to main site) -->
<aside>
<a class="identity-logo" href="#">Creative Commons</a>
<h2>Our Work Relies On You!</h2>
<h2 id="explore-heading">Our Work Relies On You!</h2>
<p>Help us keep the internet free and open.</p>
</aside>

<nav class="explore-menu">
<nav class="explore-menu" aria-labelledby="explore-heading">
<ul>
<li>
<a href="#">Global Network</a>
Expand Down
Loading