Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mobile responsiveness #264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vickova
Copy link
Contributor

@vickova vickova commented Oct 19, 2024

Fixes

Description

This pull request addresses the mobile responsiveness issues present in program-index.html and program-page.html. The changes aim to ensure that both pages display correctly on various mobile devices and screen sizes.

Technical details

  • Updated media query in vocabulary.css for better mobile layout adjustments.
  • Ensured elements that were previously overflowing on smaller screens are now properly contained within the viewport.

Tests

  • Open program-index.html and program-page.html in a browser.
  • Resize the window to simulate various mobile screen sizes or use mobile device emulation in the browser's developer tools.
  • Verify that the pages adapt to different screen widths without layout issues, such as content overflow or improper scaling.

Screenshots

Before this fix
Screenshot (313)

After this fix
Screenshot (314)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@vickova vickova requested review from a team as code owners October 19, 2024 01:05
@vickova vickova requested review from TimidRobot, Shafiya-Heena, possumbilities and nimishbongale and removed request for a team October 19, 2024 01:05
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 4b6b795
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/671305f229722c0008325b01
😎 Deploy Preview https://deploy-preview-264--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vickova
Copy link
Contributor Author

vickova commented Oct 19, 2024

@possumbilities , I noticed that this issue with mobile responsiveness still persisted. This pull request also fixes all occurrences of this which can be found in the program-index.html file and the program-page.html file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Mobile responsiveness issue on program-index.html
1 participant