-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/scroll to top #65
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,3 @@ | |||
{ | |||
"liveServer.settings.port": 5501 | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file shouldn't have been commited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll remove it and create a PR again. Hope that would help and also I want to ask if the function works as requested?
@@ -970,6 +969,7 @@ <h1>Title Here</h1> | |||
</pre> | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the extra space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll also work on this as soon as possible
Hi @Daodu111 Thank you for the contribution! After looking at it further, I'm not sure that this meets the criteria outlined in the Issue. For example:
Additionally, this does not utilize CSS pseudo elements like It also includes a new icon outside the standard icon library implementation, and should follow how icons are included within the framework already. And I believe you need to include the scroll-to-top on an existing specimen or create a new one for display/testing purposes. One could argue adding it to the I think the approach needs to be changed in several areas before it could proceed. I'll leave it open for now to leave room for you to adjust it. |
specimen/index-logo.html
Outdated
<li><a href="#">Blog</a></li> | ||
<li><a href="#">Support Us</a></li> | ||
<li><a class="attention" href="https://summit.creativecommons.org/">Global Summit 2023</a></li> | ||
<li><a href="#" class="active">Who We Are</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are not related to this PR.
Fixes
Description
This pull request adds a scroll-to-top element to enhance user experience on longer pages. The new feature allows users to easily navigate back to the top of the page with a single click.
Technical details
I implemented a scroll-to-top button using HTML and CSS only and it appears after scrolling down a little distance
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin