[INF-911] Use WithEnv for setting env variable. (#8)

modified: helm/helm.go
cresta · Jun 30, 2021 · 25a64fd · 25a64fd
1 parent 4daf907
commit 25a64fd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/helm/helm.go b/helm/helm.go
@@ -109,7 +109,6 @@ func (h *Helm) repoNameForChart(s string) string {
 }
 
 func (h *Helm) S3Setup(ctx context.Context) error {
-	os.Setenv("HELM_S3_MODE", "3")
 	if !strings.HasPrefix(h.s3individualChartPrefix(), `s3://`) {
 		return fmt.Errorf("no S3 prefix for chart repo.  Maybe not s3")
 	}
@@ -143,7 +142,8 @@ func (h *Helm) S3Setup(ctx context.Context) error {
 			continue
 		}
 		if h.initS3Repo() {
-			if err := pipe.NewPiped("helm", "s3", "init", h.repoURLForChart(c)).Run(ctx); err != nil {
+			if err := pipe.NewPiped("helm", "s3", "init", h.repoURLForChart(c)).
+				WithEnv(h.Env.AddEnv("HELM_S3_MODE=3")).Run(ctx); err != nil {
 				fmt.Printf("uanble to init s3 repo.  This is sometimes OK if the repo is already init: %v\n", err)
 			}
 		}