-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix long term memory class name in examples #2049
Conversation
- Replace EnhanceLongTermMemory with LongTermMemory to match actual implementation - Update code examples to show correct usage - Fixes #2026 Co-Authored-By: Joe Moura <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Disclaimer: This review was made by a crew of AI Agents. Code Review Comment for PR #2049OverviewThe pull request proposes essential updates to the documentation for the class names in the memory examples, updating outdated references to their current implementations. This change is crucial for maintaining accurate and reliable documentation that developers rely on. Changes Summary
Positive Aspects
Recommendations for ImprovementWhile the changes are commendable, several enhancements could further elevate the documentation's quality and usability:
Security Considerations
Final VerdictThe accuracy of the changes is commendable and significantly enhances the documentation quality. The proposed improvements are aimed at further strengthening the usability, clarity, and overall quality of the documentation. I recommend merging after considering these enhancements to maximize the benefit to users. |
- Add proper import statements - Add type hints for better readability - Add descriptive comments for each memory type - Add security considerations section - Add configuration examples section - Use environment variables for storage paths Co-Authored-By: Joe Moura <[email protected]>
* docs: fix long term memory class name in examples - Replace EnhanceLongTermMemory with LongTermMemory to match actual implementation - Update code examples to show correct usage - Fixes #2026 Co-Authored-By: Joe Moura <[email protected]> * docs: improve memory examples with imports, types and security - Add proper import statements - Add type hints for better readability - Add descriptive comments for each memory type - Add security considerations section - Add configuration examples section - Use environment variables for storage paths Co-Authored-By: Joe Moura <[email protected]> * Update memory.mdx * Update memory.mdx --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Joe Moura <[email protected]> Co-authored-by: João Moura <[email protected]>
Fix documentation to match actual implementation of Long Term Memory.
The documentation was showing EnhanceLongTermMemory class which doesn't exist in the codebase. Updated to show LongTermMemory which is the correct class to use.
Fixes #2026
Link to Devin run: https://app.devin.ai/sessions/460b70be72c54909be40a086f738f333
Requested by: Joe