Skip to content

fix: improve type annotations for config field in Crew class #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve type annotations for config field in Crew class #3567

wants to merge 1 commit into from

Conversation

devenchawla009
Copy link

  • Update config field type from Json | dict[str, Any] to dict[str, Any]
  • Fix check_config_type validator to use str instead of Json type for isinstance check
  • Update validator input type from Json to str (Json is essentially a string in Pydantic)
  • Remove TODO comment and type: ignore as typing is now accurate
  • The validator always returns dict[str, Any] regardless of input type

Resolves TODO: Improve typing in crew.py

fix: improve type annotations for config field in Crew class
1c7a0cc 
- Update config field type from Json | dict[str, Any] to dict[str, Any]
- Fix check_config_type validator to use str instead of Json type for isinstance check
- Update validator input type from Json to str (Json is essentially a string in Pydantic)
- Remove TODO comment and type: ignore as typing is now accurate
- The validator always returns dict[str, Any] regardless of input type

Resolves TODO: Improve typing in crew.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devenchawla009