fix: support nested config format for embedder configuration #3579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add EmbedderConfig TypedDict for better type safety - Fix parsing to properly handle nested 'config' key as documented - Support both 'model' and 'model_name' keys for OpenAI compatibility - Add comprehensive tests for Azure and regular OpenAI configurations - Update docstrings and examples to clarify expected formats
|
addresses #3571 |
- Update all tests to mock EMBEDDING_PROVIDERS dictionary - Fix mocking patterns for proper provider lookup
…upport - Add automatic API key injection from environment variables for all providers - Add special handling for amazon-bedrock to auto-create boto3 session - Support all 15 embedding providers with proper configuration - Fix model/model_name field conversion for backward compatibility - Add comprehensive tests for all providers and new functionality - Improve type hints with MutableMapping for config dictionaries
lorenzejay
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes embedder configuration parsing to properly handle the documented nested format with 'config' key.