feat: add option to run a listener only once (in same syntax as addEv…

…entListener)
crhallberg · Jan 29, 2024 · d7ba34f · d7ba34f
1 parent f316c99
commit d7ba34f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/themes/bootstrap3/js/common.js b/themes/bootstrap3/js/common.js
@@ -31,8 +31,14 @@ var VuFind = (function VuFind() {
       listeners[event] = [];
     }
 
-    listeners[event].push(fn);
-    return () => unlisten(event, fn);
+    const listenFn = !once : fn : (...args) => {
+      fn(...args);
+      // Automatically remove a listener we only want to run once
+      unlisten(arguments.callee);
+    };
+
+    listeners[event].push(listenFn);
+    return () => unlisten(event, listenFn);
   }
 
   function emit(event, ...args) {

diff --git a/themes/bootstrap3/js/lightbox.js b/themes/bootstrap3/js/lightbox.js
@@ -323,9 +323,8 @@ VuFind.register('lightbox', function Lightbox() {
     // onclose behavior
     if ('string' === typeof $(form).data('lightboxOnclose')) {
       VuFind.listen('lightbox.closed', function lightboxClosed() {
-        VuFind.unlisten('lightbox.closed', arguments.callee); // only once
         VuFind.evalCallback($(form).data('lightboxOnclose'), null, form);
-      });
+      }, { once: true });
     }
     // Prevent multiple submission of submit button in lightbox
     if (submit.closest(_modal).length > 0) {