Log events only related to a valid CNI configuration file. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: roman-kiselenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11762983317Details
💛 - Coveralls |
roman-kiselenko
force-pushed
the
feature/log-only-cni-config-files
branch
from
910bb50
to
0cfe056
Compare
Logs only .conf, .json and .conflist files. Signed-off-by: roman-kiselenko <[email protected]>
roman-kiselenko
force-pushed
the
feature/log-only-cni-config-files
branch
from
0cfe056
to
b661a2b
Compare
Comment on lines
+158
to
+167
| exts := map[string]bool{} | ||
| for _, ext := range []string{".conf", ".conflist", ".json"} { | ||
| exts[ext] = true | ||
| } | ||
| for { | ||
| select { | ||
| case event := <-plugin.watcher.Events: | ||
| logrus.Infof("CNI monitoring event %v", event) | ||
| if exts[filepath.Ext(event.Name)] { | ||
| logrus.Infof("CNI monitoring event %v", event) | ||
| } |
There was a problem hiding this comment.
How about avoiding the map:
exts := []string{".conf", ".conflist", ".json"}
for {
select {
case event := <-plugin.watcher.Events:
if slices.Contains(exts, filepath.Ext(event.Name)) {
logrus.Infof("CNI monitoring event %v", event)
}There was a problem hiding this comment.
I like it, I will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs only
.conf,.jsonand.conflistfiles.Context #208 (comment)
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reduce noisy log messages
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Some additional context is here.
Does this PR introduce a user-facing change?
@kwilczynski @saschagrunert PTAL