Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement format/expression in input model band definition #11

Merged
merged 10 commits into from
May 14, 2024

Conversation

fmigneault
Copy link
Collaborator

Description

Allow mlm:input to define bands with object representation:

{
  "name": "band-name",
  "format": "expr-fmt",
  "expression": "{}"
}

Using this, the model can define per-band pre-processing steps, such as, computing a virtual NDVI band consisting of an arithmetic combination of other band sources.

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make codestyle;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault added the enhancement New feature or request label May 2, 2024
@fmigneault fmigneault requested a review from rbavery May 2, 2024 02:38
@fmigneault fmigneault self-assigned this May 2, 2024
Copy link
Collaborator

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor language edits, tests and descriptions are thorough.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fmigneault fmigneault mentioned this pull request May 4, 2024
10 tasks
@fmigneault fmigneault merged commit 3f76eb9 into main May 14, 2024
8 checks passed
@fmigneault fmigneault deleted the mlm-bands branch May 14, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants