Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove example fixme notice #30

Merged
merged 1 commit into from
Jul 26, 2024
Merged

remove example fixme notice #30

merged 1 commit into from
Jul 26, 2024

Conversation

rbavery
Copy link
Collaborator

@rbavery rbavery commented Jul 25, 2024

Description

I missed removing the fix me notice on the last PR, now that we have more examples for items, no need for the fix me notice.

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault merged commit 4730fe0 into main Jul 26, 2024
8 checks passed
@fmigneault fmigneault deleted the remove-fix-me-notice branch July 26, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants