Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CLI definition to find collection config file #42

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

fmigneault
Copy link
Collaborator

Changes

  • Replace logic to resolve and load specific implementation configuration file of a populator to avoid depending on
    inconsistent caller (python <impl-module.py> vs stac-populator run <impl>).
  • Fix configuration file of populator implementation not found when package is installed.
  • Allow a populator implementation to override the desired configuration file.
  • Add missing CLI default="full" mode for CMIP6_UofT populator implementation.
  • Fix Docker entrypoint to use stac-populator to make call to the CLI more convenient.
  • Add get_logger function to avoid repeated configuration across modules.
  • Make sure that each implementation and module employs their own logger.

Copy link
Collaborator

@Nazim-crim Nazim-crim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

STACpopulator/populator_base.py Outdated Show resolved Hide resolved
STACpopulator/populator_base.py Show resolved Hide resolved
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a quick look, ok for me.

@fmigneault fmigneault merged commit ab03f0b into master Nov 28, 2023
7 checks passed
@fmigneault fmigneault deleted the cli-config-loc branch November 28, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants