-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection enhancements #53
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
19ebcf2
add assets to collections
dchandan 5011bea
add CMIP6 implementation collection assets
dchandan 5d86e2c
bug fix on return type
dchandan 5601c5c
updating UoT CMIP6 collection temporal extent
dchandan b0259f5
Updating CHANGES.md
dchandan 7aa26d1
adding ability to add collection level links
dchandan a7daa7b
changing CMIP6_UofT assets to links
dchandan 63beeae
updating CHANGED.md
dchandan cce3a36
Merge branch 'master' into collection-enhancements
dchandan 269d66a
refactoring logic for adding collection links and assets
dchandan 19412a5
bug fix in __make_collection_links
dchandan f750fa5
specify collection assets as yaml list rather than dict
dchandan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,17 @@ description: Coupled Model Intercomparison Project phase 6 | |
keywords: ['CMIP', 'CMIP6', 'WCRP', 'Climate Change'] | ||
license: "CC-BY-4.0" | ||
spatialextent: [-180, -90, 180, 90] | ||
temporalextent: ['1850-01-01', null] | ||
temporalextent: ['1850-01-01', '2500-01-01'] | ||
|
||
links: | ||
homepage: | ||
rel: about | ||
title : Project homepage | ||
target : https://wcrp-cmip.org/cmip-phase-6-cmip6/ | ||
media_type: text/html | ||
license: | ||
rel: license | ||
title : License | ||
target : https://raw.githubusercontent.com/WCRP-CMIP/CMIP6_CVs/main/LICENSE-CC-BY | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why use a dict instead of a list if the link name is dropped anyway? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good idea. Done. |
||
media_type: text/plain | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show how
2500-01-01
makes it better for rendering?The current one seems fine to me:
https://redoak.cs.toronto.edu/stac-browser/collections/CMIP6_UofT
If the final date of CMIP6 is unknown, it looks like the "until present" is ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "until present" is not ideal because it's not true. The final date for CMIP6 data is known, the maximum a simulation in the archive goes up to is year 2500. When I originally had "null" I was expecting something like STAC browser to show an undetermined/open end date, not something wrong like "until present".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a specific date imposed by CMIP6, then it is fine. I'm not familiar with that granular level of details about it.