Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first implementation prefer header for execute job #415

Merged
merged 24 commits into from
Mar 31, 2022
Merged

first implementation prefer header for execute job #415

merged 24 commits into from
Mar 31, 2022

Conversation

fmigneault
Copy link
Collaborator

Changes

  • Support Prefer header with wait or respond-async directives to select Job execution mode either
    as synchronous or asynchronous task, according to supported jobControlOptions of the relevant Process
    being executed (resolves [Feature] Support Prefer header and improve sync/async execution #247).
  • Increase minor version of all builtin processes that will now be executable in wither (a)synchronous modes.
  • Add weaver.exec_sync_max_wait and weaver.quote_sync_max_wait settings allowing custom definition for the
    maximum duration that can be specified to wait for a synchronous response from task workers.
  • Fix Allow omitting execute outputs #375.

@fmigneault fmigneault requested a review from dbyrns March 15, 2022 21:55
@fmigneault fmigneault self-assigned this Mar 15, 2022
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. feature/opensearch Issue related to OpenSearch functionalities. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support feature/providers Issue related to providers convertion to WPS-REST processes. labels Mar 15, 2022
@github-actions github-actions bot added the feature/cli Issues or features related to CLI operations. label Mar 15, 2022
@github-actions github-actions bot added the ci/operations Related to CI operations (actions, execution, install, builds, etc.) label Mar 16, 2022
@github-actions github-actions bot added the feature/db Related to database or datatype manipulation. label Mar 16, 2022
@fmigneault fmigneault mentioned this pull request Mar 17, 2022
Merged
@fmigneault
Copy link
Collaborator Author

@dbyrns
You can review directly #419 to save yourself some duplicate changes.

dbyrns
dbyrns approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that #419 is approved, you're good to go with this one too!

@fmigneault fmigneault merged commit 51050bc into master Mar 31, 2022
@fmigneault fmigneault deleted the job-prefer-header branch March 31, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyrns dbyrns dbyrns approved these changes

Assignees

@fmigneault fmigneault

Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. feature/opensearch Issue related to OpenSearch functionalities. feature/providers Issue related to providers convertion to WPS-REST processes. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow omitting execute outputs [Feature] Support Prefer header and improve sync/async execution
2 participants
@fmigneault @dbyrns