Fixed cover art being dropped on file split #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that even though my source file had an embedded cover art, it was being lost during the split. This fix involves:
-an
flag from the split command (as the cover art is embedded in a video stream, we need the video now)-ss -t
flags before the-i
(See https://superuser.com/questions/758338/keep-album-art-with-ffmpeg-while-cutting-a-mp3-file)Because of how the
ffmpy
library syntax works, that wasn't possible by keeping a single source file, so I had to split the split (heh) process into one ffmpeg command for each track - it's a tad bit slower, but can't think of another way to do this.