Added pre-commit hook, and dependencies #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreyfeldroy
requested changes
Oct 8, 2023
Co-authored-by: Audrey Roy Greenfeld <[email protected]>
|
Hi @audreyfeldroy I have made the change, if there is anything else to change or add, please tell me. |
audreyfeldroy
approved these changes
Oct 8, 2023
audreyfeldroy
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a pre-commit hook, and dependencies
What I did
I read about the pre-commit hooks and ruff from both the links that you provided in the issue. I created the .pre-commit-config.yaml file in the root folder. I looked at the hooks on the github of pre-commit and from there took the below mentioned last two hooks.
I didn't know much so I have added the "ruff", "end-of-file-fixer" and "check-merge-conflict" only.
: Please tell me if I need to make any changes. Thank You! 😀
feature: #58