Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple questions code into question code #84

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Decouple questions code into question code #84

merged 1 commit into from
Oct 22, 2023

Conversation

pydanny
Copy link
Member

@pydanny pydanny commented Oct 22, 2023 •
edited
Loading

This PR does the following to address #83:

  • Removes questions code from transcripts.py and places into the questions.py module
  • Renames the settings variables for the questions code to be more explicit
  • Does not attempt to get the questions code to work

audreyfeldroy
audreyfeldroy approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @pydanny!

@audreyfeldroy audreyfeldroy merged commit c693ad4 into main Oct 22, 2023
1 check passed
@audreyfeldroy audreyfeldroy deleted the ISSUE-83/isolate-questions-to-own-command branch October 22, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audreyfeldroy audreyfeldroy audreyfeldroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pydanny @audreyfeldroy