This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Add ability to stream response to file #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
commented
Jul 11, 2024
| helpValue: 'Example: report.xlsx', | ||
| char: 'S', | ||
| exclusive: ['include'], | ||
| }), |
There was a problem hiding this comment.
If you have a better name for this flag, let me know. The S character is used by curl for "show error"
iowillhoit
commented
Jul 11, 2024
| body: Flags.string({ | ||
| summary: | ||
| 'The file to use as the body for the request (use "-" to read from standard input).', | ||
| 'The file to use as the body for the request (use "-" to read from standard input, use "" for an empty body).', |
There was a problem hiding this comment.
This matches curl
iowillhoit
commented
Jul 11, 2024
| const split = header.split(':'); | ||
| if (split.length !== 2) { | ||
| const [key, ...rest] = header.split(':') | ||
| const value = rest.join(':').trim(); |
There was a problem hiding this comment.
I was copying headers from chrome dev tools and notice that "Origin:https://gus.lightning.force.com" would not parse correctly because of the additional :
cristiand391
approved these changes
Jul 15, 2024
|
QA notes: ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
body(similar tocurl):. This allows for:s to exist in the header valueNote: "ignore whitespace" will make the diff cleaner
Testing
You can test this by running a report and accepting an xlxs file (api docs)
Example command would be:
sf org api '/services/data/v61.0/analytics/reports/00OEE000001ZdM52AK' -o gus -X POST -H "Accept:application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" --body "" -S "report.xlsx"Confirm the file opens in Excel, Numbers, Google Sheets, etc
What issues does this PR fix or reference?
@W-16215223@