Fix unit tests

src/RedisRateLimiting/Concurrency/RedisConcurrencyRateLimiter.cs

@@ -76,6 +76,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
 
         protected override RateLimitLease AttemptAcquireCore(int permitCount)
         {
+            // https://github.com/cristipufu/aspnetcore-redis-rate-limiting/issues/66
             return FailedLease;
         }
 

src/RedisRateLimiting/FixedWindow/RedisFixedWindowRateLimiter.cs

@@ -62,6 +62,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
 
         protected override RateLimitLease AttemptAcquireCore(int permitCount)
         {
+            // https://github.com/cristipufu/aspnetcore-redis-rate-limiting/issues/66
             return FailedLease;
         }
 

src/RedisRateLimiting/SlidingWindow/RedisSlidingWindowRateLimiter.cs

@@ -62,6 +62,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
 
         protected override RateLimitLease AttemptAcquireCore(int permitCount)
         {
+            // https://github.com/cristipufu/aspnetcore-redis-rate-limiting/issues/66
             return FailedLease;
         }
 

src/RedisRateLimiting/TokenBucket/RedisTokenBucketRateLimiter.cs

@@ -67,6 +67,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
 
         protected override RateLimitLease AttemptAcquireCore(int permitCount)
         {
+            // https://github.com/cristipufu/aspnetcore-redis-rate-limiting/issues/66
             return FailedLease;
         }
 

test/RedisRateLimiting.Tests/UnitTests/ConcurrencyUnitTests.cs

@@ -48,9 +48,7 @@ public async Task ThrowsWhenAcquiringMoreThanLimit()
                     QueueLimit = 1,
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
-            var ex = Assert.Throws<ArgumentOutOfRangeException>(() => limiter.AttemptAcquire(2));
-            Assert.Equal("permitCount", ex.ParamName);
-            ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
+            var ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
             Assert.Equal("permitCount", ex.ParamName);
         }
 
@@ -89,7 +87,7 @@ public async Task CanAcquireAsyncResource()
             Assert.Equal(1, stats.CurrentAvailablePermits);
         }
 
-        [Fact]
+        [Fact(Skip = "Sync always returns failed lease")]
         public void CanAcquireResource()
         {
             using var limiter = new RedisConcurrencyRateLimiter<string>(
@@ -161,7 +159,7 @@ public async Task FailsWhenQueuingMoreThanLimit()
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
 
-            using var lease = limiter.AttemptAcquire();
+            using var lease = await limiter.AcquireAsync();
             var wait = limiter.AcquireAsync();
 
             var failedLease = await limiter.AcquireAsync();
@@ -182,7 +180,7 @@ public async Task QueueAvailableAfterQueueLimitHitAndResourcesBecomeAvailable()
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
 
-            var lease = limiter.AttemptAcquire();
+            var lease = await limiter.AcquireAsync();
             var wait = limiter.AcquireAsync();
 
             await Task.Delay(1000);

test/RedisRateLimiting.Tests/UnitTests/FixedWindowUnitTests.cs

@@ -57,9 +57,7 @@ public async Task ThrowsWhenAcquiringMoreThanLimit()
                     Window = TimeSpan.FromMinutes(1),
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
-            var ex = Assert.Throws<ArgumentOutOfRangeException>(() => limiter.AttemptAcquire(2));
-            Assert.Equal("permitCount", ex.ParamName);
-            ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
+            var ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
             Assert.Equal("permitCount", ex.ParamName);
         }
 

test/RedisRateLimiting.Tests/UnitTests/SlidingWindowUnitTests.cs

@@ -64,9 +64,7 @@ public async Task ThrowsWhenAcquiringMoreThanLimit()
                     Window = TimeSpan.FromMinutes(1),
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
-            var ex = Assert.Throws<ArgumentOutOfRangeException>(() => limiter.AttemptAcquire(2));
-            Assert.Equal("permitCount", ex.ParamName);
-            ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
+            var ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
             Assert.Equal("permitCount", ex.ParamName);
         }
 
@@ -110,7 +108,7 @@ public async Task CanAcquireAsyncResourceWithSmallWindow()
                 new RedisSlidingWindowRateLimiterOptions
                 {
                     PermitLimit = 1,
-                    Window = TimeSpan.FromMilliseconds(100),
+                    Window = TimeSpan.FromMilliseconds(600),
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
 
@@ -120,7 +118,7 @@ public async Task CanAcquireAsyncResourceWithSmallWindow()
             using var lease2 = await limiter.AcquireAsync();
             Assert.False(lease2.IsAcquired);
 
-            await Task.Delay(TimeSpan.FromMilliseconds(100));
+            await Task.Delay(TimeSpan.FromMilliseconds(600));
 
             using var lease3 = await limiter.AcquireAsync();
             Assert.True(lease3.IsAcquired);

test/RedisRateLimiting.Tests/UnitTests/TokenBucketUnitTests.cs

@@ -77,9 +77,7 @@ public async Task ThrowsWhenAcquiringMoreThanLimit()
                     ReplenishmentPeriod = TimeSpan.FromMinutes(1),
                     ConnectionMultiplexerFactory = Fixture.ConnectionMultiplexerFactory,
                 });
-            var ex = Assert.Throws<ArgumentOutOfRangeException>(() => limiter.AttemptAcquire(2));
-            Assert.Equal("permitCount", ex.ParamName);
-            ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
+            var ex = await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await limiter.AcquireAsync(2));
             Assert.Equal("permitCount", ex.ParamName);
         }