Skip to content

Commit

Permalink
Finally fixed the bug where marathon were not releasing the lock
Browse files Browse the repository at this point in the history
This was appearing because the KillStreamWatcher was waiting for all
tasks to die, and not only the overdue ones.

This was appearing most of the time when tasks were Unreachable because
they sometimes re-appear while marathon already scheduled new ones.

JIRA: MESOS-4345
  • Loading branch information
Lqp1 committed Oct 27, 2020
1 parent 3c94a36 commit 4cae841
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ class SchedulerActions(

if (instancesToDecommission.nonEmpty) {
logger.info(s"Adjusting goals for instances ${instancesToDecommission.map(_.instanceId)} (${GoalChangeReason.OverCapacity})")
val instancesAreTerminal = KillStreamWatcher.watchForKilledTasks(instanceTracker.instanceUpdates, instances).runWith(Sink.ignore)
val instancesAreTerminal = KillStreamWatcher.watchForKilledTasks(instanceTracker.instanceUpdates, instancesToDecommission).runWith(Sink.ignore)

// Race condition with line 421. The instances we loaded might not exist anymore, e.g. the agent
// might have been removed and the instance expunged.
Expand Down

0 comments on commit 4cae841

Please sign in to comment.