Use a constructor for MessageIterator

This allows creating MessageIterators for tests
criteo · Nov 7, 2023 · f700670 · f700670
1 parent 4470942
commit f700670
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/notify.go b/notify.go
@@ -58,6 +58,17 @@ type MessageIterator struct {
 	Message Message
 }
 
+func NewMessageIterator(b []byte) *MessageIterator {
+	return &MessageIterator{
+		b: b,
+		Message: Message{
+			Args: &ArgIterator{
+				b: b,
+			},
+		},
+	}
+}
+
 func (i *MessageIterator) Error() error {
 	return i.err
 }
@@ -97,14 +108,7 @@ func (i *MessageIterator) Next() bool {
 }
 
 func (c *conn) handleNotify(f Frame, acks chan Frame) error {
-	messages := &MessageIterator{
-		b: f.data,
-		Message: Message{
-			Args: &ArgIterator{
-				b: f.data,
-			},
-		},
-	}
+	messages := NewMessageIterator(f.data)
 
 	actions, err := c.handler(messages)
 	if err != nil {