Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create ApplicationData folder if not exists #94

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

joaoopereira
Copy link
Member

This PR solves the scenario (for now only seen in linux) when the ApplicationData folder doesn't exists:
image

before:
image

after:
image

@joaoopereira
Copy link
Member Author

I also want to porpose that all our references to FileSystem should be changed to IFileSystem, so we can use System.IO.Abstractions to mock the filesystem and add more unit testing :)

@vitorpmoreira
Copy link
Contributor

vitorpmoreira commented Nov 21, 2024

I also want to porpose that all our references to FileSystem should be changed to IFileSystem, so we can use System.IO.Abstractions to mock the filesystem and add more unit testing :)

I'll open a WI for this. Thanks #119488

Copy link
Contributor

@vitorpmoreira vitorpmoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please version bump the portal-sdk, we don't have an automatic bump yet.
You just need to change the Version.props

@joaoopereira
Copy link
Member Author

Please version bump the portal-sdk, we don't have an automatic bump yet. You just need to change the Version.props

done ✅

@joaoopereira joaoopereira merged commit 4bf8879 into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants