Fetch notifications

[PavanTeja2005]

Fix #19
I have added the notification fetching function "get_notification"

If _from and _to are given the notifications are fetched.
If only _from is given, from that date notifications are fetched
If none is given, previous 30 days notification are fetched

[cro2003]

On my end its showing []

[PavanTeja2005]

It's because there are no notifications in the last 30 days. I have checked the site.

You can try using _from and _to..

[cro2003]

I see, as these are archived notices. So what you can do is that if there's no date is passed in argument just give all the important alerts which is showed in the pop when we open rgpv homepage + archived notice if its within one month range. If dates are passed and there are no notifications just give all the important alerts which is showed in the pop when we open rgpv homepage, here remember there can be case like i passed 01-08-2024 & 02-8-2024 there are notification between them but after these dates archived notifications are available in this case it shoud return []. In a bit i will be sharing some examples which will show how it should work.

[cro2003]

Example 1: No Arguments
Show all the Notification which are in the homepage of rgpv + archived notification which are within 1 month time, for instance today is 08-10-2024, check for the notification which are after 08-09-2024 in the archived notification.

[cro2003]

Example 2: Argument Passed (_from: 01-09-2024, _to: 10-09-2024)
Show Notification from 01-09-2024 in archived notification + All the notifications from the Homepage (as after 04-09-2024 there are no archived notification but new notifications can be there as the _to date is 10-09-2024)

[cro2003]

Example 3: Argument Passed (_from: 10-09-2024, _to: 01-10-2024)
There are no notification from 10-09-2024 in archived notification, the latest notification was on 04-09-2024. So now in this case we can directly show the notification from the homepage

[PavanTeja2005]

There is no date data available. but is this okay?

[PavanTeja2005]

Archived case is fine, but it doesn't have any date info.

[cro2003]

Yea its cool but just add a key of date and write the value as "NOT AVAILABLE", "date": "NOT AVAILABLE"

[cro2003]

Also please make sure all the notification have the links to it (even with archived notification) as without link they will be useless.

[cro2003]

Example 4: Argument Passed (_from: 01-09-2024, _to: 03-09-2024)
In this Case there are no notification in the archived between the given dates, also we dont have to give the all notification from the homepage as the latest archived notification is after the _to date.
Output: []

[cro2003]

Example 5: Argument Passed (_from: 01-08-2024, _to: 01-09-2024)
As we can see that there are archived notification between these days so we only have to show that notifications, we dont have to give the all notification from the homepage as the latest archived notification is after the _to date.

[cro2003]

Also add this functionality in info_api.py instead of result_api.py

[PavanTeja2005]

Check the new codes

Output:

[cro2003]

Can you please share the Output of the all 5 Examples which i have given above

[PavanTeja2005]

Example 1: No Arguments
Show all the Notification which are in the homepage of rgpv + archived notification which are within 1 month time, for instance today is 08-10-2024, check for the notification which are after 08-09-2024 in the archived notification.

[PavanTeja2005]

Example 2: Argument Passed (_from: 01-09-2024, _to: 10-09-2024)
Show Notification from 01-09-2024 in archived notification + All the notifications from the Homepage (as after 04-09-2024 there are no archived notification but new notifications can be there as the _to date is 10-09-2024)

[PavanTeja2005]

Example 3: Argument Passed (_from: 10-09-2024, _to: 01-10-2024)
There are no notification from 10-09-2024 in archived notification, the latest notification was on 04-09-2024. So now in this case we can directly show the notification from the homepage
Start

end

[PavanTeja2005]

Example 4: Argument Passed (_from: 01-09-2024, _to: 03-09-2024)
In this Case there are no notification in the archived between the given dates, also we dont have to give the all notification from the homepage as the latest archived notification is after the _to date.
Output: []

[PavanTeja2005]

Example 5: Argument Passed (_from: 01-08-2024, _to: 01-09-2024)
As we can see that there are archived notification between these days so we only have to show that notifications, we dont have to give the all notification from the homepage as the latest archived notification is after the _to date.
image

[PavanTeja2005]

What should I do with the archived notifications? As it's using js we cannot use requests. Using selenium will increase the project's complexity.

[PavanTeja2005]

I meant the links in the archived notifications.

[cro2003]

I see, let me check what be done here.

[PavanTeja2005]

Did you check?

[cro2003]

Yea I checked, so just give this link https://www.rgpv.ac.in/Uni/ImpNoticeArchive.aspx for the archived notification

[PavanTeja2005]

The last change done. Please approve.

And please let me know if there are any important features to be added more in the project.

[PavanTeja2005]

PLease merge this

[cro2003]

Hey So Sorry, I am still busy. I will review and merge it within 48 hours.

[PavanTeja2005]

Thank you

[cro2003]

I have tested the Code from my Side too and it works well. Before merging it please Move this notification code to the info_api.py file instead of result_api.py file and also modify the init.py file and at last the Alert from the rgpv homepage title also shows "Click here to View" along with the title so remove that too.

[PavanTeja2005]

Modified according to requirements

[cro2003]

get_notification() & fetch_alerts() are still available in the result_api.py and it would be great you can move both both get_notification() & fetch_alerts() in the class as the static method, right now they are both outside the class [info_api.py file].