Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test selection #33

Merged
merged 25 commits into from
Aug 2, 2024
Merged

Fix test selection #33

merged 25 commits into from
Aug 2, 2024

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Aug 1, 2024

Fixes #32.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 68.63636% with 138 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (e8cdbe9) to head (6ed466c).

Files Patch % Lines
...main/java/cz/crcs/ectester/common/util/ECUtil.java 54.16% 22 Missing ⚠️
...r/standalone/test/suites/StandaloneWrongSuite.java 0.00% 14 Missing ⚠️
...main/java/cz/crcs/ectester/common/ec/EC_Curve.java 57.14% 10 Missing and 2 partials ⚠️
...a/cz/crcs/ectester/reader/test/CardWrongSuite.java 0.00% 11 Missing ⚠️
...ter/standalone/test/base/KeyAgreementTestable.java 55.00% 9 Missing ⚠️
...andalone/test/suites/StandaloneCompositeSuite.java 0.00% 8 Missing ⚠️
...in/java/cz/crcs/ectester/common/util/CardUtil.java 0.00% 7 Missing ⚠️
...va/cz/crcs/ectester/reader/test/CardMiscSuite.java 53.33% 4 Missing and 3 partials ⚠️
...rcs/ectester/common/output/BaseTextTestWriter.java 0.00% 6 Missing ⚠️
.../crcs/ectester/reader/test/CardCompositeSuite.java 0.00% 6 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
- Coverage     70.00%   61.27%   -8.73%     
- Complexity      432     1307     +875     
============================================
  Files            55      133      +78     
  Lines          3064     9212    +6148     
  Branches        377     1261     +884     
============================================
+ Hits           2145     5645    +3500     
- Misses          747     2983    +2236     
- Partials        172      584     +412     
Components Coverage Δ
Applet 69.83% <ø> (∅)
Common 58.12% <55.14%> (∅)
Reader 50.45% <73.55%> (∅)
Standalone 71.09% <72.64%> (+1.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY J08nY marked this pull request as ready for review August 2, 2024 16:41
@J08nY J08nY merged commit 7647d4b into master Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test selection does not work as expected in reader
2 participants