Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
lavy-blaggan committed Mar 25, 2024
1 parent 17c3777 commit 48b08fc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/Cronofy/Responses/UserInfoResponse.cs
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,10 @@ internal sealed class ConferencingProfileResponse
public string ProfileRelinkUrl { get; set; }

/// <summary>
/// Converts the response into a <see cref="Cronofy.ConferencingProfile"/>.
/// Converts the response into a <see cref="Cronofy.UserInfo.ConferencingProfile"/>.
/// </summary>
/// <returns>
/// A <see cref="Cronofy.ConferencingProfile"/> based upon the response.
/// A <see cref="Cronofy.UserInfo.ConferencingProfile"/> based upon the response.
/// </returns>
public UserInfo.ConferencingProfile ToConferencingProfile()
{
Expand All @@ -339,7 +339,7 @@ public UserInfo.ConferencingProfile ToConferencingProfile()
Id = this.ProfileId,
Name = this.ProfileName,
Connected = this.ProfileConnected,
RelinkUrl = this.ProfileRelinkUrl
RelinkUrl = this.ProfileRelinkUrl,
};
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Cronofy/UserInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ public override bool Equals(object obj)
/// to the current <see cref="Cronofy.UserInfo.ConferencingProfile"/>; otherwise,
/// <c>false</c>.
/// </returns>
public bool Equals(Profile other)
public bool Equals(ConferencingProfile other)
{
return other != null
&& this.Id == other.Id
Expand Down
8 changes: 5 additions & 3 deletions test/Cronofy.Test/CronofyAccountClientTests/GetUserInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,20 @@ public void CanGetUserInfoForAccount()
},
ConferencingProfiles = new UserInfo.ConferencingProfile[]
{
new UserInfo.ConferencingProfile {
new UserInfo.ConferencingProfile
{
Connected = true,
Id = "pro_jknsdfk234",
Name = "[email protected]",
ProviderName = "zoom",
},
new UserInfo.ConferencingProfile {
new UserInfo.ConferencingProfile
{
Connected = false,
Id = "pro_gfmdsg51qa",
Name = "[email protected]",
RelinkUrl = "https://app.cronofy.com/v2/relink/go_to?email=example%40cronofy.com",
ProviderName = "go_to1",
ProviderName = "go_to",
},
},
Email = "[email protected]",
Expand Down

0 comments on commit 48b08fc

Please sign in to comment.