This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
MOD: Upgrade hackney & fix crash on startup #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we start up multiple instances of the bot at the same time the discord api will rate limit us and we will have to wait for the specified amount of milliseconds. As the expected keys are not present in the payload, json["url"] will return nil and hence nil <> "?v=6&encoding=json" will crash.
Zarathustra2
changed the title
|
@cronokirby This can be now merged. Fixed the pipeline as well as a potential crash which can happen at startup if multiple instances are being spawned at the same time! Also congrats to 100 Stars! :) |
|
Very nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For references: edgurgel/httpoison#414
Also:
If we start up multiple instances of the bot at the same time
the discord api will rate limit us and we will have to wait for the
specified amount of milliseconds.
As the expected keys are not present in the payload, json["url"]
will return nil and hence nil <> "?v=6&encoding=json" will crash.