Problem: l2 gas price is not adjusted with the exchange rate of CRO #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinyuCRO
approved these changes
Jun 24, 2024
|
LGTM, one question, will it be updated again before introducing the Oracle? If yes, should it be a config or environment variable? |
|
I don't think so. The oracle PR is almost completed but it will still require one or two weeks before it get release in an official version. We will roll this change on Wednesday so that we can start working of the fee conversion flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Use a constant multiplier as a temporary solution while the Oracle solution is still under development