Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Operator address is not displayed when using GKMS #54

Closed
wants to merge 2 commits into from

Conversation

calvinaco
Copy link
Collaborator

@calvinaco calvinaco commented Jul 11, 2024

Solution: Display operator address on instantiation

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@calvinaco calvinaco requested a review from JayT106 July 11, 2024 17:39
@calvinaco calvinaco changed the title Gkms display address Problem: Operator address is not displayed when using GKMS Jul 11, 2024
@JayT106
Copy link
Contributor

JayT106 commented Jul 11, 2024

I think it's be printed in

tracing::info!("KMS signer address: {:?}", hex::encode(signer.address()));

However, the zksync_eth_signer log need to be set in the chain env file. The default is not set. Maybe just set it by default?

@calvinaco
Copy link
Collaborator Author

I think it's be printed in

tracing::info!("KMS signer address: {:?}", hex::encode(signer.address()));

However, the zksync_eth_signer log need to be set in the chain env file. The default is not set. Maybe just set it by default?

Sorry @JayT106 can you elaborate?

@JayT106
Copy link
Contributor

JayT106 commented Jul 12, 2024

I think it's be printed in

tracing::info!("KMS signer address: {:?}", hex::encode(signer.address()));

However, the zksync_eth_signer log need to be set in the chain env file. The default is not set. Maybe just set it by default?

Sorry @JayT106 can you elaborate?

Sure, you can check this commit:
e3b4da8

@thomas-nguy thomas-nguy closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants